Enable reporting gRPC codes as labels in cortex and ingester_client request duration metrics #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duricanikolic
force-pushed
the
yuri/handling-errors-new
branch
3 times, most recently
from
44c42b7 to
c7dc5b5
Compare
…equest duration metrics Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/handling-errors-new
branch
from
c7dc5b5 to
6647195
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
force-pushed
the
yuri/handling-errors-new
branch
from
603f696 to
bee61b0
Compare
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
Signed-off-by: Yuri Nikolic <[email protected]>
duricanikolic
requested review from
pstibrany
and removed request for
pstibrany
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR does the following changes:
dskitto revision b3823cb.status_codelabel incortex_request_duration_secondsmetrics. Before this PR, all gRPC codes were reported as "error".status_codelabel incortex_ingester_client_request_duration_secondsmetrics. Before this PR, all gRPC codes were reported as "error".status_codes (In order to achieve this, the pattern for recognizing valid status codes should be changed from[a-z]+to[a-zA-Z]+, since gRPC status codes contain upper cases letters too, e.g.,OK,FailedPrecondition,Canceled, etc.).Note: The biggest change introduced by this PR is that successful
status_codelabels ofcortex_request_duration_secondsandcortex_ingester_client_request_duration_secondsmetrics have changed from respectivelysuccessand2xxtoOK.Which issue(s) this PR fixes or relates to
Part of #6008
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]